Hello @DxPru, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

This change also need to modify hal_rpi_pico.
Please update west.yml after zephyrproject-rtos/hal_rpi_pico#9 solved.

This change also need to modify hal_rpi_pico. Please update west.yml after zephyrproject-rtos/hal_rpi_pico#9 solved.

does it?
this seems to be fixing a huge amount of failing tests for rp2040 boards (basically anything that has flash or hwinfo enabled), and doesn't seem to depend on anything in the HAL from what i can see?

Example of a broken test:

west build -p -b w5500_evb_pico/rp2040 tests/drivers/hwinfo/api  -T drivers.hwinfo.api

fixed the compliance issues

This change also need to modify hal_rpi_pico. Please update west.yml after zephyrproject-rtos/hal_rpi_pico#9 solved.

does it? this seems to be fixing a huge amount of failing tests for rp2040 boards (basically anything that has flash or hwinfo enabled), and doesn't seem to depend on anything in the HAL from what i can see?

Example of a broken test:

west build -p -b w5500_evb_pico/rp2040 tests/drivers/hwinfo/api  -T drivers.hwinfo.api

I checked. Indeed, there is no need to change HAL at now.
In the RP2350 case does require HAL modification, but since it does not yet have flash functionality, it is not an issue at the moment.
Thank you confirmation.

Hi @DxPru!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Nice work, also, my bad for breaking things. These aren't build targets that I tested against beforehand, in hindsight this was dumb of me.

@kartben , is there a specific CI task and/or local command I can be running? What drew your attention to this in you comment above; is this part of the "build all on all" build that gets mentioned sometimes?

This change also need to modify hal_rpi_pico. Please update west.yml after zephyrproject-rtos/hal_rpi_pico#9 solved.

does it? this seems to be fixing a huge amount of failing tests for rp2040 boards (basically anything that has flash or hwinfo enabled), and doesn't seem to depend on anything in the HAL from what i can see?

Example of a broken test:

west build -p -b w5500_evb_pico/rp2040 tests/drivers/hwinfo/api  -T drivers.hwinfo.api